Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2941433002: MD Settings: fix auto-focus on sync page. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index 8078686bd65191aa99cdd123b62bb0a8c771bf77..218fb3d4ea6e3be9f6755744dd646617e0988fb8 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -216,8 +216,8 @@ Polymer({
// Focus the password input box if password is needed to start sync.
if (this.syncPrefs.passphraseRequired) {
- // Async to allow the dom-if templates to render first.
- this.async(function() {
+ // wait for the dom-if templates to render and subpage to become visible.
dpapad 2017/06/13 01:27:34 s/wait/Wait
scottchen 2017/06/14 00:52:13 Done.
+ listenOnce(document, 'show-container', function() {
var input = /** @type {!PaperInputElement} */ (
this.$$('#existingPassphraseInput'));
input.inputElement.focus();
@@ -225,6 +225,8 @@ Polymer({
}
},
+
dpapad 2017/06/13 01:27:34 Remove new blank lines?
scottchen 2017/06/14 00:52:13 Done.
+
/**
* Handler for when the sync all data types checkbox is changed.
* @param {!Event} event
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698