Add the 'crossGettersSetters' flag to ClassHierarchy.forEachOverridePair().

Add the 'crossGettersSetters' flag to ClassHierarchy.forEachOverridePair().

We need to be able to get 'overrides' of setters with getters and vise
versa to support top-level inference.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/bcf179c9fa5c79cc34e334a0ba541907eef60347

[Paul Berry, 2017-06-16 22:05:12]

Implementation looks ok, but I have concerns about the tests.

https://codereview.chromium.org/2941363002/diff/1/pkg/kernel/test/class_hiera...
File pkg/kernel/test/class_hierarchy_test.dart (right):

https://codereview.chromium.org/2941363002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:197: ]);
We should also test that if `crossGettersSetters: false` ispassed to
forEachOverridePair, no overrides are reported.

https://codereview.chromium.org/2941363002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:948: (Member declaredMember, Member
interfaceMember, bool isSetter_) {
We are no longer checking that forEachOverridePair() passes in the correct value
for `isSetter`.  If there are clients that rely on `isSetter`, we should keep
testing it.  If there aren't, we should remove it.

[scheglov, 2017-06-16 23:49:42]

PTAL

https://codereview.chromium.org/2941363002/diff/1/pkg/kernel/test/class_hiera...
File pkg/kernel/test/class_hierarchy_test.dart (right):

https://codereview.chromium.org/2941363002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:948: (Member declaredMember, Member
interfaceMember, bool isSetter_) {
On 2017/06/16 22:05:11, Paul Berry wrote:
> We are no longer checking that forEachOverridePair() passes in the correct
value
> for `isSetter`.  If there are clients that rely on `isSetter`, we should keep
> testing it.  If there aren't, we should remove it.

Done.

[Paul Berry, 2017-06-17 13:00:20]

lgtm

[scheglov, 2017-06-18 01:32:46]

Description was changed from

==========
Add the 'crossGettersSetters' flag to ClassHierarchy.forEachOverridePair().

We need to be able to get 'overrides' of setters with getters and vise
versa to support top-level inference.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Add the 'crossGettersSetters' flag to ClassHierarchy.forEachOverridePair().

We need to be able to get 'overrides' of setters with getters and vise
versa to support top-level inference.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/bcf179c9fa5c79cc34e334a0ba541907eef60347
==========

[scheglov, 2017-06-18 01:32:48]

Committed patchset #2 (id:20001) manually as
bcf179c9fa5c79cc34e334a0ba541907eef60347 (presubmit successful).