Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 29413003: Fix VM crash when ClosureMirror.findInContext operates on a fake function. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe
Visibility:
Public.

Description

Fix VM crash when ClosureMirror.findInContext operates on a fake function. R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=28937

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/find_in_context_fake_function_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-18 19:38:46 UTC) #1
gbracha
test lgtm.
7 years, 2 months ago (2013-10-18 19:54:05 UTC) #2
siva
lgtm
7 years, 2 months ago (2013-10-19 00:37:58 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-21 17:10:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698