Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: pkg/shelf/lib/src/shelf_unmodifiable_map.dart

Issue 294123011: pkg/shelf: added `url` and `scriptName` named params to Request.change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: doc comment tweak Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/lib/src/request.dart ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/lib/src/shelf_unmodifiable_map.dart
diff --git a/pkg/shelf/lib/src/shelf_unmodifiable_map.dart b/pkg/shelf/lib/src/shelf_unmodifiable_map.dart
index 34775f092f7ab93200c52084b8acb378c02a2d23..9634c8538a12a790489c3a8f432afeeb2b28d02d 100644
--- a/pkg/shelf/lib/src/shelf_unmodifiable_map.dart
+++ b/pkg/shelf/lib/src/shelf_unmodifiable_map.dart
@@ -6,12 +6,13 @@ library shelf.shelf_unmodifiable_map;
import 'dart:collection';
-// TODO(kevmoo): use UnmodifiableMapView from SDK once 1.4 ships
+// TODO(kevmoo): MapView lacks a const ctor, so we have to use DelegatingMap
+// from pkg/collection - https://codereview.chromium.org/294093003/
import 'package:collection/wrappers.dart' as pc;
/// A simple wrapper over [pc.UnmodifiableMapView] which avoids re-wrapping
/// itself.
-class ShelfUnmodifiableMap<V> extends pc.UnmodifiableMapView<String, V> {
+class ShelfUnmodifiableMap<V> extends UnmodifiableMapView<String, V> {
/// If [source] is a [ShelfUnmodifiableMap] with matching [ignoreKeyCase],
/// then [source] is returned.
///
« no previous file with comments | « pkg/shelf/lib/src/request.dart ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698