Issue 294123006: [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294123006: [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled (take 2) (Closed)

Created:
6 years, 7 months ago by Ilya Sherman

Modified:
6 years, 7 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled (take 2) This is a recommit of [ https://src.chromium.org/viewvc/chrome?view=rev&revision=271798 ], fixing IWYU. BUG=374296 TEST=compiles R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272057

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -58 lines)			Patch
M	chrome/browser/metrics/metrics_service_unittest.cc	View		4 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/browser/metrics/metrics_services_manager.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/metrics/metrics_services_manager.cc	View	1	2 chunks	+35 lines, -2 lines	0 comments	Download
M	chrome/browser/metrics/metrics_state_manager.h	View		5 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/browser/metrics/metrics_state_manager.cc	View		4 chunks	+11 lines, -29 lines	0 comments	Download
M	chrome/browser/metrics/metrics_state_manager_unittest.cc	View		3 chunks	+18 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

Ilya Sherman

Patch set 1 is the original patch; 2 is the revised one.

6 years, 7 months ago (2014-05-21 08:44:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/294123006/20001

6 years, 7 months ago (2014-05-21 08:47:22 UTC) #4

Message was sent while issue was closed.

Change committed as 272057