Move some sync/notifier to components/invalidation

Move some sync/notifier to components/invalidation

Moves many of the files in sync/notifier to components/invalidation.

This change does not introduce any new dependencies.  The relevant
dependency rules both before and after this change should be:
- chrome/browser/invalidation and chrome in general depend on
  components/invalidation.
- components/invalidation depends on sync/notifier and sync in
  general.
- sync/notifier, components/invalidation, and various parts of
  chrome all depend on sync/internal_api/public.

The eventual goal is to move all of sync/notifier into
components/invalidation.  The invalidation-related parts of
sync/internal_api/public should be moved to components/invalidation,
too.  This will allow us to remove the deopendencies from
components/invalidation to sync, and remove sync's dependencies on
cacheinvalidation and libjingle.

This change is a regression in terms of shared library componentization.
the files in the sync/notifier folder could be built as a shared
library.  The files in compononents/invalidation do not support this
yet.  The SYNC_EXPORT declarations in the moved files have been changed
to INVALIDATION_EXPORT so as to not lose this information, but the
macros are currently #defined to no-ops.

This change does not attempt to rename any classes or namespaces.
Many of the files ported from sync/notifier still use the syncer
namespace.  Some, like SyncSystemResources, still have names tied
to their sync heritage.  This will be addressed in future CLs.

Some non-trivial or non-obvious changes include:
- invalidator_state.h was moved to sync/internal_api/public/base so it
could be shared by both sync/ and components/invalidation.  This should
be fixed in a future CL.
- FromNotifierReason was split out of invalidator_state.h and moved to
the newly-created components/invalidator_reason_util.h

TBR=zea,rtenneti,mallinath,dcheng
BUG=259559
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274350

[rlarocque, 2014-05-21 20:24:49]

Here's the first part of moving sync/notifier to components/invalidation.  I
started by moving sync_system_resources, then kept moving more and more files
until I got to a point where everything would compile.  This is the result.

Please review.

[pavely, 2014-05-22 19:50:45]

lgtm

[rlarocque, 2014-05-22 20:03:26]

Turns out I need owners for new DEPS additions.  These are really just DEPS
moves, so I'm going to use TBR for this.

Adding TBRs:
zea for DEPS on google_apis/gcm
rtenneti for DEPS on net/
mallinath for DEPS on talk/xmpp
dcheng for push_messaging_apitest.cc

[rlarocque, 2014-05-22 20:05:23]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-05-22 20:09:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/294123004/70114

[ramant (doing other things), 2014-05-22 20:51:57]

components/invalidation/DEPS changes LGTM

[commit-bot: I haz the power, 2014-05-22 23:54:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8325)

[commit-bot: I haz the power, 2014-05-23 00:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 00:04:02]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8384)

[rlarocque, 2014-05-27 22:10:23]

Unfortunately, one of those failures is legit and hard to fix.

The sync standalone test binaries (sync_listen_notifications and sync_client)
are creating a circular reference in the gyp files.  This fails only on Mac OS,
since only the Mac OS build scripts bother to check for circular references in
gyp files.

I think I know how to fix it, but that's going to take another CL.  This CL is
blocked until the prerequisite  lands.

[rlarocque, 2014-05-30 17:46:39]

On 2014/05/27 22:10:23, rlarocque wrote:
> Unfortunately, one of those failures is legit and hard to fix.
> 
> The sync standalone test binaries (sync_listen_notifications and sync_client)
> are creating a circular reference in the gyp files.  This fails only on Mac
OS,
> since only the Mac OS build scripts bother to check for circular references in
> gyp files.
> 
> I think I know how to fix it, but that's going to take another CL.  This CL is
> blocked until the prerequisite  lands.

I've landed r273665 which should fix the circular dependency.  The latest patch
set has been rebased on top of it.

Most of the parts that have been reviewed remain unchanged, so this probably
doesn't need to a re-review.  Though you should feel free to take another look
if you want.  You can never have too many reviews.

I'll add Nick M. for review of the parts that did change.

[maniscalco, 2014-05-30 17:55:25]

On 2014/05/30 17:46:39, rlarocque wrote:
> On 2014/05/27 22:10:23, rlarocque wrote:
> > Unfortunately, one of those failures is legit and hard to fix.
> > 
> > The sync standalone test binaries (sync_listen_notifications and
sync_client)
> > are creating a circular reference in the gyp files.  This fails only on Mac
> OS,
> > since only the Mac OS build scripts bother to check for circular references
in
> > gyp files.
> > 
> > I think I know how to fix it, but that's going to take another CL.  This CL
is
> > blocked until the prerequisite  lands.
> 
> I've landed r273665 which should fix the circular dependency.  The latest
patch
> set has been rebased on top of it.
> 
> Most of the parts that have been reviewed remain unchanged, so this probably
> doesn't need to a re-review.  Though you should feel free to take another look
> if you want.  You can never have too many reviews.
> 
> I'll add Nick M. for review of the parts that did change.

gyp changes lgtm

[rlarocque, 2014-05-30 18:49:13]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-05-30 18:51:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/294123004/130001

[commit-bot: I haz the power, 2014-05-31 00:48:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-31 02:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 02:22:49]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[rlarocque, 2014-06-02 17:48:34]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-02 17:49:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/294123004/130001

[rlarocque, 2014-06-02 17:50:04]

The CQ bit was unchecked by rlarocque@chromium.org

[rlarocque, 2014-06-02 18:11:17]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-02 18:12:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/294123004/150001

[commit-bot: I haz the power, 2014-06-02 22:17:53]

Change committed as 274350

[rlarocque, 2014-06-02 23:13:36]

A revert of this CL has been created in
https://codereview.chromium.org/308413002/ by rlarocque@chromium.org.

The reason for reverting is: Passed the CQ but broke the buildbot..