Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 294123003: Prevent settings hardening UI from appearing when no resets have occurred. (Closed)

Created:
6 years, 7 months ago by Cait (Slow)
Modified:
6 years, 7 months ago
Reviewers:
Bernhard Bauer, gab
CC:
erikwright (departed), robertshield
Visibility:
Public.

Description

Prevent settings hardening UI from appearing when no resets have occurred. TEST=manual: Force a reset (manually edit a protected pref). Expect to see reset UI in chrome://settings, dismiss it, restart Chrome, expect no reset UI. BUG=374360 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/prefs/pref_hash_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Cait (Slow)
Bernhard: PTAL. This CL fixes an issue introduced in https://codereview.chromium.org/257003007/ where we were changing a ...
6 years, 7 months ago (2014-05-20 20:56:43 UTC) #1
gab
lgtm, thanks for fixing this while I'm away!
6 years, 7 months ago (2014-05-21 01:29:26 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 7 months ago (2014-05-21 01:29:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/294123003/1
6 years, 7 months ago (2014-05-21 01:31:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 07:35:30 UTC) #5
Bernhard Bauer
LGTM. Is there a reason why chromium-reviews is not on CC here?
6 years, 7 months ago (2014-05-21 07:37:25 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:17:05 UTC) #7
Message was sent while issue was closed.
Change committed as 271957

Powered by Google App Engine
This is Rietveld 408576698