Issue 2941143002: The Dev console could come up broken if debuggerModel is null. Added sentry around addEventListene…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2941143002: The Dev console could come up broken if debuggerModel is null. Added sentry around addEventListene… (Closed)

Created:
3 years, 6 months ago by terry

Modified:
3 years, 6 months ago

Reviewers:
Jacob

CC:
reviews+dom_dartlang.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Target Ref:
refs/heads/releases/2661_work

Visibility:
Public.

More Reviews

Description

The Dev console could come up broken if debuggerModel is null. Added sentry around addEventListeners being called. Issue https://github.com/dart-lang/sdk/issues/29873#issuecomment-308828667 R=jacobr@google.com Committed: https://src.chromium.org/viewvc/chrome/branches/dart/dartium/src?view=rev&revision=74026ff2ae007bdfecf6bb4e22798bdf312760c3

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

3 years, 6 months ago (2017-06-15 21:18:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74026ff2ae007bdfecf6bb4e22798bdf312760c3.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages