Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 294113003: [Android] Convert to DeviceUtils versions of WaitUntilFullyBooted and GetExternalStoragePath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/gtest/test_package_apk.py
diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py
index 9d3dac541ea580c49c464cdfca19238abc94634b..9f077b6b90f8b3047de183d5502a8e71cccd8c8a 100644
--- a/build/android/pylib/gtest/test_package_apk.py
+++ b/build/android/pylib/gtest/test_package_apk.py
@@ -85,9 +85,14 @@ class TestPackageApk(TestPackage):
# Content shell creates a profile on the sdscard which accumulates cache
# files over time.
if self.suite_name == 'content_browsertests':
- device.old_interface.RunShellCommand(
- 'rm -r %s/content_shell' % device.old_interface.GetExternalStorage(),
- timeout_time=60 * 2)
+ try:
+ device.old_interface.RunShellCommand(
+ 'rm -r %s/content_shell' % device.GetExternalStoragePath(),
+ timeout_time=60 * 2)
+ except device_errors.CommandFailedError:
+ # TODO(jbudorick) Handle this exception appropriately once the
+ # conversions are done.
craigdh 2014/05/21 22:25:00 just fyi, I think the style guide is agnostic abou
+ pass
#override
def CreateCommandLineFileOnDevice(self, device, test_filter, test_arguments):

Powered by Google App Engine
This is Rietveld 408576698