pkg/testing/lib/src/analyze.dart - Issue 2941123005: Fix "?." usage in analyze.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2941123005: Fix "?." usage in analyze.dart. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/testing/lib/src/analyze.dart

diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart

index 8719df746a90c69c5b4097c9aedb69639e5db9b5..fa2ccd5c6846f80e59f75debde0a974df4131c51 100644

--- a/pkg/testing/lib/src/analyze.dart

+++ b/pkg/testing/lib/src/analyze.dart

@@ -237,7 +237,7 @@ Future<Null> analyzeUris(

await for (AnalyzerDiagnostic diagnostic in diagnostics) {

if (diagnostic.uri != null) {

String path = toFilePath(diagnostic.uri);

- if (!(analysisOptions?.path.contains("/pkg/compiler/") ?? false) &&

+ if (!(analysisOptions?.path?.contains("/pkg/compiler/") ?? false) &&

diagnostic.code.startsWith("STRONG_MODE") &&

(path.startsWith("pkg/compiler/") ||

path.startsWith("tests/compiler/dart2js/"))) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »