Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart

Issue 2941093002: Only attempt to do type inference on fields that lack a declared type. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
index daf330104b23416cb397acfaacfbddea94b7159b..b00f560acfedbc7147ea140213b27ccb205f9809 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
@@ -28,8 +28,6 @@ import 'package:kernel/ast.dart'
ThisExpression,
VariableGet;
-import 'package:front_end/src/scanner/token.dart' show Token;
-
import '../modifier.dart' show constMask, finalMask, staticMask;
import '../names.dart' show indexGetName;
@@ -120,14 +118,7 @@ class KernelEnumBuilder extends SourceClassBuilder
/// String toString() => { 0: ‘E.id0’, . . ., n-1: ‘E.idn-1’}[index]
/// }
members["index"] = new KernelFieldBuilder(
- null,
- intType,
- "index",
- finalMask,
- parent,
- charOffset,
- // Synthetic token to signal this field is initialized.
- new Token.eof(charOffset));
+ null, intType, "index", finalMask, parent, charOffset, null, true);
KernelConstructorBuilder constructorBuilder = new KernelConstructorBuilder(
null,
constMask,
@@ -145,15 +136,8 @@ class KernelEnumBuilder extends SourceClassBuilder
constructors[""] = constructorBuilder;
int index = 0;
List<MapEntry> toStringEntries = <MapEntry>[];
- KernelFieldBuilder valuesBuilder = new KernelFieldBuilder(
- null,
- listType,
- "values",
- constMask | staticMask,
- parent,
- charOffset,
- // Synthetic token to signal this field is initialized.
- new Token.eof(charOffset));
+ KernelFieldBuilder valuesBuilder = new KernelFieldBuilder(null, listType,
+ "values", constMask | staticMask, parent, charOffset, null, true);
members["values"] = valuesBuilder;
KernelProcedureBuilder toStringBuilder = new KernelProcedureBuilder(
null,
@@ -185,15 +169,8 @@ class KernelEnumBuilder extends SourceClassBuilder
constantNamesAndOffsets[i] = null;
continue;
}
- KernelFieldBuilder fieldBuilder = new KernelFieldBuilder(
- null,
- selfType,
- name,
- constMask | staticMask,
- parent,
- charOffset,
- // Synthetic token to signal this field is initialized.
- new Token.eof(charOffset));
+ KernelFieldBuilder fieldBuilder = new KernelFieldBuilder(null, selfType,
+ name, constMask | staticMask, parent, charOffset, null, true);
members[name] = fieldBuilder;
toStringEntries.add(new MapEntry(
new IntLiteral(index), new StringLiteral("$className.$name")));
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698