Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2941093002: Only attempt to do type inference on fields that lack a declared type. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only attempt to do type inference on fields that lack a declared type. This avoids the need for KernelField._implicitlyTyped. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/058c29f0a5fb15a29b1f1d4066eefa337fde320a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -119 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 4 chunks +5 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 4 chunks +18 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +0 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +14 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 3 chunks +44 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-15 18:31:19 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-15 20:30:40 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 058c29f0a5fb15a29b1f1d4066eefa337fde320a (presubmit successful).
3 years, 6 months ago (2017-06-15 20:41:14 UTC) #5
ahe
lgtm Nice!
3 years, 6 months ago (2017-06-16 13:31:32 UTC) #6
scheglov
3 years, 6 months ago (2017-06-16 15:19:57 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698