Issue 2941083002: Remove pkg/front_end's remaining dependencies on pkg/analyzer.

Issue 2941083002: Remove pkg/front_end's remaining dependencies on pkg/analyzer. (Closed)

Created:
3 years, 6 months ago by Paul Berry

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), danrubel, kevmoo

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Remove pkg/front_end's remaining dependencies on pkg/analyzer. The remaining dependencies were in code that isn't being used anymore, so I just removed the dead code. R=danrubel@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/da3d611aaf19bb652f31fe94b49e8b507c8bfb78

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -529 lines)			Patch
D	pkg/front_end/lib/resolved_ast_generator.dart	View		1 chunk	+0 lines, -61 lines	0 comments	Download
D	pkg/front_end/lib/src/libraries_reader.dart	View		1 chunk	+0 lines, -201 lines	0 comments	Download
M	pkg/front_end/pubspec.yaml	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	pkg/front_end/test/src/base/libraries_reader_test.dart	View		1 chunk	+0 lines, -239 lines	0 comments	Download
M	pkg/front_end/test/src/base/test_all.dart	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	pkg/front_end/test/subpackage_relationships_test.dart	View		7 chunks	+3 lines, -25 lines	0 comments	Download

Total messages: 11 (3 generated)

kevmoo

DBQ: might could there be a corresponding pubspec update? To remove pkg/analyzer?

3 years, 6 months ago (2017-06-15 18:53:32 UTC) #4

Paul Berry

On 2017/06/15 18:53:32, kevmoo wrote: > DBQ: might could there be a corresponding pubspec update? ...

3 years, 6 months ago (2017-06-15 19:26:45 UTC) #5

kevmoo

On 2017/06/15 19:26:45, Paul Berry wrote: > On 2017/06/15 18:53:32, kevmoo wrote: > > DBQ: ...

3 years, 6 months ago (2017-06-15 19:27:26 UTC) #6

Paul Berry

3 years, 6 months ago (2017-06-15 20:47:34 UTC) #11

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
da3d611aaf19bb652f31fe94b49e8b507c8bfb78 (presubmit successful).