Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/inferrer/locals_handler.dart

Issue 2941033002: Finish strong mode cleaning of dart2js. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/node_tracer.dart » ('j') | pkg/compiler/lib/src/inferrer/node_tracer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/locals_handler.dart
diff --git a/pkg/compiler/lib/src/inferrer/locals_handler.dart b/pkg/compiler/lib/src/inferrer/locals_handler.dart
index 945572fc60fad82b67feee2efd0fcb3f114fac94..01293fbcb8fb93815f38f9b4f827b7486757b772 100644
--- a/pkg/compiler/lib/src/inferrer/locals_handler.dart
+++ b/pkg/compiler/lib/src/inferrer/locals_handler.dart
@@ -191,6 +191,8 @@ class ArgumentsTypes extends IterableMixin<TypeInformation> {
if (positional[i] != other.positional[i]) return false;
}
named.forEach((name, type) {
+ // TODO(ahe): This is a bug.
ahe 2017/06/15 09:36:39 I'll file an issue about this and update the comme
ahe 2017/06/15 11:41:57 Done.
+ // ignore: RETURN_OF_INVALID_TYPE
if (other.named[name] != type) return false;
});
return true;
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/node_tracer.dart » ('j') | pkg/compiler/lib/src/inferrer/node_tracer.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698