Chromium Code Reviews| Index: chrome/browser/permissions/permission_prompt_android.cc |
| diff --git a/chrome/browser/permissions/permission_prompt_android.cc b/chrome/browser/permissions/permission_prompt_android.cc |
| index 9893147833314b1f6e2ca639c72794b6066951ed..4cafdfa4f96e4ecfb64ca63e3e465b4fecd09823 100644 |
| --- a/chrome/browser/permissions/permission_prompt_android.cc |
| +++ b/chrome/browser/permissions/permission_prompt_android.cc |
| @@ -9,6 +9,7 @@ |
| #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android.h" |
| #include "chrome/browser/permissions/permission_dialog_delegate.h" |
| #include "chrome/browser/permissions/permission_request.h" |
| +#include "chrome/browser/permissions/permission_uma_util.h" |
| #include "chrome/common/url_constants.h" |
| #include "chrome/grit/generated_resources.h" |
| #include "chrome/grit/theme_resources.h" |
| @@ -77,18 +78,33 @@ void PermissionPromptAndroid::Closing() { |
| } |
| void PermissionPromptAndroid::TogglePersist(bool value) { |
| + persist_ = value; |
| if (delegate_) |
| delegate_->TogglePersist(value); |
| } |
| void PermissionPromptAndroid::Accept() { |
| - if (delegate_) |
| + if (delegate_) { |
| + if (ShouldShowPersistenceToggle()) { |
| + for (const PermissionRequest* request : delegate_->Requests()) { |
| + PermissionUmaUtil::PermissionPromptAcceptedWithPersistenceToggle( |
| + request->GetContentSettingsType(), persist_); |
|
raymes
2017/06/15 04:41:36
Dom said there is a way to test the histograms fro
Timothy Loh
2017/06/15 06:00:58
I added an assert in GeolocationTest.java, could d
|
| + } |
| + } |
| delegate_->Accept(); |
| + } |
| } |
| void PermissionPromptAndroid::Deny() { |
| - if (delegate_) |
| + if (delegate_) { |
| + if (ShouldShowPersistenceToggle()) { |
| + for (const PermissionRequest* request : delegate_->Requests()) { |
| + PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle( |
| + request->GetContentSettingsType(), persist_); |
| + } |
| + } |
| delegate_->Deny(); |
| + } |
| } |
| size_t PermissionPromptAndroid::PermissionCount() const { |