Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2940983003: [autofill] Add UKM for field type prediction quality and autofill outcome. (Closed)
Patch Set: fix a comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 // the query response. 1009 // the query response.
1010 if (queried_forms.empty()) 1010 if (queried_forms.empty())
1011 return; 1011 return;
1012 1012
1013 // Parse and store the server predictions. 1013 // Parse and store the server predictions.
1014 FormStructure::ParseQueryResponse(std::move(response), queried_forms, 1014 FormStructure::ParseQueryResponse(std::move(response), queried_forms,
1015 client_->GetRapporServiceImpl()); 1015 client_->GetRapporServiceImpl());
1016 1016
1017 // Will log quality metrics for each FormStructure based on the presence of 1017 // Will log quality metrics for each FormStructure based on the presence of
1018 // autocomplete attributes, if available. 1018 // autocomplete attributes, if available.
1019 for (FormStructure* cur_form : queried_forms) 1019 for (FormStructure* cur_form : queried_forms) {
1020 cur_form->LogQualityMetricsBasedOnAutocomplete(); 1020 cur_form->LogQualityMetricsBasedOnAutocomplete(
1021 form_interactions_ukm_logger_.get());
1022 }
1021 1023
1022 // Forward form structures to the password generation manager to detect 1024 // Forward form structures to the password generation manager to detect
1023 // account creation forms. 1025 // account creation forms.
1024 driver()->PropagateAutofillPredictions(queried_forms); 1026 driver()->PropagateAutofillPredictions(queried_forms);
1025 1027
1026 // If the corresponding flag is set, annotate forms with the predicted types. 1028 // If the corresponding flag is set, annotate forms with the predicted types.
1027 driver()->SendAutofillTypePredictionsToRenderer(queried_forms); 1029 driver()->SendAutofillTypePredictionsToRenderer(queried_forms);
1028 } 1030 }
1029 1031
1030 IdentityProvider* AutofillManager::GetIdentityProvider() { 1032 IdentityProvider* AutofillManager::GetIdentityProvider() {
(...skipping 1338 matching lines...) Expand 10 before | Expand all | Expand 10 after
2369 #endif // ENABLE_FORM_DEBUG_DUMP 2371 #endif // ENABLE_FORM_DEBUG_DUMP
2370 2372
2371 void AutofillManager::LogCardUploadDecisions(int upload_decision_metrics) { 2373 void AutofillManager::LogCardUploadDecisions(int upload_decision_metrics) {
2372 AutofillMetrics::LogCardUploadDecisionMetrics(upload_decision_metrics); 2374 AutofillMetrics::LogCardUploadDecisionMetrics(upload_decision_metrics);
2373 AutofillMetrics::LogCardUploadDecisionsUkm(client_->GetUkmRecorder(), 2375 AutofillMetrics::LogCardUploadDecisionsUkm(client_->GetUkmRecorder(),
2374 pending_upload_request_url_, 2376 pending_upload_request_url_,
2375 upload_decision_metrics); 2377 upload_decision_metrics);
2376 } 2378 }
2377 2379
2378 } // namespace autofill 2380 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698