chrome/browser/ui/webui/safe_browsing_ui.h - Issue 2940963002: Added the chrome://safe-browsing/ page as part of the chrome://about

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/safe_browsing_ui.h

Issue 2940963002: Added the chrome://safe-browsing/ page as part of the chrome://about (Closed)

Patch Set: "Moved files to components\... and removed the username for the incognito case" Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
	Peter Kasting 2017/06/19 21:06:47 Nit: No (c); see https://chromium.googlesource.com Nit: No (c); see https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md... . Also applies in .cc file.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_SAFE_BROWSING_UI_H_

	6 #define CHROME_BROWSER_UI_WEBUI_SAFE_BROWSING_UI_H_

	7

	8 #include "base/macros.h"

	9 #include "content/public/browser/url_data_source.h"

	10 #include "content/public/browser/web_ui_controller.h"

	11 #include "ui/base/layout.h"
	Peter Kasting 2017/06/19 21:06:47 Nit: It looks like at least url_data_source.h and Nit: It looks like at least url_data_source.h and layout.h are not used by this header and can be removed.
	12

	13 // The WebUI for chrome://safe-browsing
	Peter Kasting 2017/06/19 21:06:47 Nit: Trailing period on comments Nit: Trailing period on comments
	14 class SafeBrowsingUI : public content::WebUIController {

	15 public:

	16 explicit SafeBrowsingUI(content::WebUI* web_ui);

	17 ~SafeBrowsingUI() override;

	18

	19 private:

	20 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingUI);

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_WEBUI_SAFE_BROWSING_UI_H_

OLD	NEW