Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 294093012: Remove conflicting function declaration. (Closed)

Created:
6 years, 7 months ago by earthdok
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org
Visibility:
Public.

Description

Remove conflicting function declaration. We used to declare sanitizer interface functions explicitly because we didn't have access to sanitizer interface headers. That has not been the case for a while. Also, a recent clang roll changed the signature of __sanitizer_sandbox_on_notify() causing conflicts with our own declaration. BUG=none TBR=jln@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272885

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/common/sandbox_linux/sandbox_linux.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
earthdok
6 years, 7 months ago (2014-05-23 18:11:27 UTC) #1
jln (very slow on Chromium)
lgtm
6 years, 7 months ago (2014-05-23 22:20:57 UTC) #2
jln (very slow on Chromium)
https://chromiumcodereview.appspot.com/294093012/diff/1/content/common/sandbox_linux/sandbox_linux.cc File content/common/sandbox_linux/sandbox_linux.cc (right): https://chromiumcodereview.appspot.com/294093012/diff/1/content/common/sandbox_linux/sandbox_linux.cc#newcode139 content/common/sandbox_linux/sandbox_linux.cc:139: __sanitizer_sandbox_on_notify(/*reserved*/ NULL); should that comment ("/* reserved */") be ...
6 years, 7 months ago (2014-05-23 23:38:38 UTC) #3
earthdok
https://codereview.chromium.org/294093012/diff/1/content/common/sandbox_linux/sandbox_linux.cc File content/common/sandbox_linux/sandbox_linux.cc (right): https://codereview.chromium.org/294093012/diff/1/content/common/sandbox_linux/sandbox_linux.cc#newcode139 content/common/sandbox_linux/sandbox_linux.cc:139: __sanitizer_sandbox_on_notify(/*reserved*/ NULL); On 2014/05/23 23:38:38, jln wrote: > should ...
6 years, 7 months ago (2014-05-26 11:58:05 UTC) #4
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 7 months ago (2014-05-26 11:58:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/294093012/20001
6 years, 7 months ago (2014-05-26 11:58:36 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 23:52:34 UTC) #7
Message was sent while issue was closed.
Change committed as 272885

Powered by Google App Engine
This is Rietveld 408576698