Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 294093006: Change install deps android to always install OpenJDK 7. (Closed)

Created:
6 years, 7 months ago by navabi
Modified:
6 years, 7 months ago
Reviewers:
Yusuf, klobag, Yaron, yfriedman, zty
CC:
chromium-reviews
Visibility:
Public.

Description

Change install deps android to always install OpenJDK 7. L bots need OpenJDK 7 and OpenJDK 7 works when building with older SDK's. Also, this removes the awkward way we had to install Oracle's JDK. BUG=353155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M build/install-build-deps-android.sh View 1 chunk +27 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
navabi
6 years, 7 months ago (2014-05-22 09:22:16 UTC) #1
Yaron
lgtm I think there are several build instructions that still mention the old jdk. Please ...
6 years, 7 months ago (2014-05-22 17:22:26 UTC) #2
navabi
On 2014/05/22 17:22:26, Yaron wrote: > lgtm > > I think there are several build ...
6 years, 7 months ago (2014-05-22 21:26:58 UTC) #3
navabi
The CQ bit was checked by navabi@google.com
6 years, 7 months ago (2014-05-22 21:27:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/294093006/1
6 years, 7 months ago (2014-05-22 21:28:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 00:44:28 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 09:42:41 UTC) #7
Message was sent while issue was closed.
Change committed as 272456

Powered by Google App Engine
This is Rietveld 408576698