Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 294093002: Changed JSON formatting more, workaround bug where SkStringPrintf causes encoding issues (Closed)

Created:
6 years, 7 months ago by kelvinly
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Changed JSON formatting more, workaround bug where SkStringPrintf causes encoding issues BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M bench/ResultsWriter.h View 1 5 chunks +18 lines, -10 lines 0 comments Download
M include/utils/SkJSONCPP.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kelvinly
Not entirely sure why (or if) SkStringPrintf was causing the problems, but this seems to ...
6 years, 7 months ago (2014-05-20 16:19:19 UTC) #1
benchen
https://codereview.chromium.org/294093002/diff/1/bench/ResultsWriter.h File bench/ResultsWriter.h (right): https://codereview.chromium.org/294093002/diff/1/bench/ResultsWriter.h#newcode164 bench/ResultsWriter.h:164: std::vector<const char*> names; Did you use it anywhere?
6 years, 7 months ago (2014-05-20 16:29:12 UTC) #2
kelvinly
https://codereview.chromium.org/294093002/diff/1/bench/ResultsWriter.h File bench/ResultsWriter.h (right): https://codereview.chromium.org/294093002/diff/1/bench/ResultsWriter.h#newcode164 bench/ResultsWriter.h:164: std::vector<const char*> names; On 2014/05/20 16:29:13, benchen wrote: > ...
6 years, 7 months ago (2014-05-20 16:33:40 UTC) #3
benchen
LGTM, thanks.
6 years, 7 months ago (2014-05-20 16:35:15 UTC) #4
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 7 months ago (2014-05-20 17:08:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/294093002/10001
6 years, 7 months ago (2014-05-20 17:08:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 17:08:34 UTC) #7
commit-bot: I haz the power
Presubmit check for 294093002-10001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-05-20 17:08:35 UTC) #8
kelvinly
6 years, 7 months ago (2014-05-20 17:10:32 UTC) #9
reed1
lgtm
6 years, 7 months ago (2014-05-20 17:16:35 UTC) #10
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 7 months ago (2014-05-20 17:29:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/294093002/10001
6 years, 7 months ago (2014-05-20 17:29:26 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:35:26 UTC) #13
Message was sent while issue was closed.
Change committed as 14808

Powered by Google App Engine
This is Rietveld 408576698