Add checks to make sure new front_end package dependencies are not added.

Add checks to make sure new front_end package dependencies are not added.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/6bc0baf131e5e6e1a10221c8c422d88e1550d067

[Paul Berry, 2017-06-15 12:53:49]

paulberry@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-15 17:45:57]

lgtm, thanks!

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:19: final
allowedPackageDependencies = [
do we need to also make the distinction between dev and non-dev dependencies?

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:289: '$package is listed
in allowedPackageDependencies, but is not used');
nit: maybe split line

[Paul Berry, 2017-06-15 17:58:28]

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:19: final
allowedPackageDependencies = [
On 2017/06/15 17:45:57, Siggi Cherem (dart-lang) wrote:
> do we need to also make the distinction between dev and non-dev dependencies?

This script only checks files in pkg/front_end/lib, so this list excludes dev
dependencies.

I've updated the comment to clarify this.

https://codereview.chromium.org/2940893004/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:289: '$package is listed
in allowedPackageDependencies, but is not used');
On 2017/06/15 17:45:57, Siggi Cherem (dart-lang) wrote:
> nit: maybe split line

Done.

[Paul Berry, 2017-06-15 18:19:01]

Description was changed from

==========
Add checks to make sure new front_end package dependencies are not added.
==========

to

==========
Add checks to make sure new front_end package dependencies are not added.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6bc0baf131e5e6e1a10221c8c422d88e1550d067
==========

[Paul Berry, 2017-06-15 18:19:02]

Committed patchset #1 (id:1) manually as
6bc0baf131e5e6e1a10221c8c422d88e1550d067 (presubmit successful).