[Extensions] Pass EventFilteringInfo directly in DispatchEvent message

extensions/renderer/native_extension_bindings_system.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/native_extension_bindings_system.h"
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "content/public/common/console_message_level.h"
 #include "content/public/common/content_switches.h"
@@ skipping 463 matching lines @@
     if (!success.IsJust() || !success.FromJust()) {
       LOG(ERROR) << "Failed to create API on Chrome object.";
       return;
     }
   }
 }
 
 void NativeExtensionBindingsSystem::DispatchEventInContext(
     const std::string& event_name,
     const base::ListValue* event_args,
-    const base::DictionaryValue* filtering_info_dict,
+    const EventFilteringInfo* filtering_info,
     ScriptContext* context) {
   v8::HandleScope handle_scope(context->isolate());
   v8::Context::Scope context_scope(context->v8_context());
-  EventFilteringInfo filter;
-  if (filtering_info_dict)
-    filter = EventFilteringInfo(*filtering_info_dict);
-  api_system_.FireEventInContext(event_name, context->v8_context(), *event_args,
-                                 filter);
+  api_system_.FireEventInContext(
+      event_name, context->v8_context(), *event_args,
+      filtering_info ? *filtering_info : EventFilteringInfo());

[lazyboy, 2017/06/15 17:12:23]

Is there a reason FireEventInContext doesn't take EventFilteringInfo* (instead
of const&)? We could avoid creating empty EventFilteringInfo() in that case, and
isn't that the common scenario?

[Devlin, 2017/06/15 18:01:06]

Nope, it probably should.  I noticed that too, and was going to make a change
separately (it's goes a bit far down).  Does that SGTY?  Or would you prefer it
in this CL?

[lazyboy, 2017/06/15 18:06:43]

Separate CL sounds good! Thanks.

 }
 
 bool NativeExtensionBindingsSystem::HasEventListenerInContext(
     const std::string& event_name,
     ScriptContext* context) {
   v8::HandleScope handle_scope(context->isolate());
   return api_system_.event_handler()->HasListenerForEvent(
       event_name, context->v8_context());
 }
 
@@ skipping 194 matching lines @@
     v8::Local<v8::Value>* binding_util_out) {
   gin::Handle<APIBindingJSUtil> handle = gin::CreateHandle(
       context->GetIsolate(),
       new APIBindingJSUtil(
           api_system_.type_reference_map(), api_system_.request_handler(),
           api_system_.event_handler(), base::Bind(&CallJsFunction)));
   *binding_util_out = handle.ToV8();
 }
 
 }  // namespace extensions