Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/gn/ninja_target_writer_unittest.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)
Patch Set: Fix compilation after rebase. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_group_target_writer_unittest.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer_unittest.cc
diff --git a/tools/gn/ninja_target_writer_unittest.cc b/tools/gn/ninja_target_writer_unittest.cc
index 55bbde05db5aaa9bf054076138897b0cbe81d8f1..6bc2866458d7335ef2ca4941aa9cd321cccb3c43 100644
--- a/tools/gn/ninja_target_writer_unittest.cc
+++ b/tools/gn/ninja_target_writer_unittest.cc
@@ -35,7 +35,7 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
Err err;
// Make a base target that's a hard dep (action).
- Target base_target(setup.settings(), Label(SourceDir("//foo/"), "base"));
+ Target base_target(setup.settings(), Label(SourceDir("//foo/"), "base"), {});
base_target.set_output_type(Target::ACTION);
base_target.visibility().SetPublic();
base_target.SetToolchain(setup.toolchain());
@@ -43,7 +43,7 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
// Dependent target that also includes a source prerequisite (should get
// included) and a source (should not be included).
- Target target(setup.settings(), Label(SourceDir("//foo/"), "target"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "target"), {});
target.set_output_type(Target::EXECUTABLE);
target.visibility().SetPublic();
target.SetToolchain(setup.toolchain());
@@ -53,7 +53,7 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
// Dependent action to test that action sources will be treated the same as
// inputs.
- Target action(setup.settings(), Label(SourceDir("//foo/"), "action"));
+ Target action(setup.settings(), Label(SourceDir("//foo/"), "action"), {});
action.set_output_type(Target::ACTION);
action.visibility().SetPublic();
action.SetToolchain(setup.toolchain());
@@ -115,14 +115,14 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDepWithToolchainDeps) {
// because it would be a circular dependency (the target depends on its
// toolchain, and the toolchain depends on this target).
Target toolchain_dep_target(setup.settings(),
- Label(SourceDir("//foo/"), "setup"));
+ Label(SourceDir("//foo/"), "setup"), {});
toolchain_dep_target.set_output_type(Target::ACTION);
toolchain_dep_target.SetToolchain(setup.toolchain());
ASSERT_TRUE(toolchain_dep_target.OnResolved(&err));
setup.toolchain()->deps().push_back(LabelTargetPair(&toolchain_dep_target));
// Make a binary target
- Target target(setup.settings(), Label(SourceDir("//foo/"), "target"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "target"), {});
target.set_output_type(Target::EXECUTABLE);
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));
« no previous file with comments | « tools/gn/ninja_group_target_writer_unittest.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698