tools/gn/ninja_copy_target_writer_unittest.cc - Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_copy_target_writer_unittest.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)

Patch Set: Fix compilation after rebase. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_copy_target_writer_unittest.cc

diff --git a/tools/gn/ninja_copy_target_writer_unittest.cc b/tools/gn/ninja_copy_target_writer_unittest.cc

index 44973a7198f8225b1b571cea0498a71d88bbd247..acd27afc299644412a8c23918ad019a7dda0ab8b 100644

--- a/tools/gn/ninja_copy_target_writer_unittest.cc

+++ b/tools/gn/ninja_copy_target_writer_unittest.cc

@@ -15,7 +15,7 @@ TEST(NinjaCopyTargetWriter, Run) {

Err err;

TestWithScope setup;

- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});

target.set_output_type(Target::COPY_FILES);

target.sources().push_back(SourceFile("//foo/input1.txt"));

@@ -45,7 +45,7 @@ TEST(NinjaCopyTargetWriter, ToolchainDeps) {

Err err;

TestWithScope setup;

- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});

target.set_output_type(Target::COPY_FILES);

target.sources().push_back(SourceFile("//foo/input1.txt"));

@@ -72,7 +72,7 @@ TEST(NinjaCopyTargetWriter, OrderOnlyDeps) {

Err err;

TestWithScope setup;

- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});

target.set_output_type(Target::COPY_FILES);

target.sources().push_back(SourceFile("//foo/input1.txt"));

target.action_values().outputs() =