Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)
Patch Set: Fix compilation after rebase. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer_unittest.cc
diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc
index 2d427656477c4d57bf8c22984651202b5cd1a989..e24fb0d1299e4acdec7c0488327892c4265c62d7 100644
--- a/tools/gn/ninja_action_target_writer_unittest.cc
+++ b/tools/gn/ninja_action_target_writer_unittest.cc
@@ -17,7 +17,7 @@ TEST(NinjaActionTargetWriter, WriteOutputFilesForBuildLine) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION_FOREACH);
target.action_values().outputs() = SubstitutionList::MakeForTest(
"//out/Debug/gen/a b{{source_name_part}}.h",
@@ -41,7 +41,7 @@ TEST(NinjaActionTargetWriter, ActionNoSources) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION);
target.action_values().set_script(SourceFile("//foo/script.py"));
@@ -80,7 +80,7 @@ TEST(NinjaActionTargetWriter, ActionNoSourcesConsole) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION);
target.action_values().set_script(SourceFile("//foo/script.py"));
@@ -89,7 +89,7 @@ TEST(NinjaActionTargetWriter, ActionNoSourcesConsole) {
target.action_values().outputs() =
SubstitutionList::MakeForTest("//out/Debug/foo.out");
- Pool pool(setup.settings(), Label(SourceDir("//foo/"), "pool"));
+ Pool pool(setup.settings(), Label(SourceDir("//foo/"), "pool"), {});
pool.set_console(true);
target.action_values().set_pool(LabelPtrPair<Pool>(&pool));
@@ -124,7 +124,7 @@ TEST(NinjaActionTargetWriter, ActionWithSources) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION);
target.action_values().set_script(SourceFile("//foo/script.py"));
@@ -167,19 +167,19 @@ TEST(NinjaActionTargetWriter, ForEach) {
// so they have a nice platform-independent stamp file that can appear in the
// output (rather than having to worry about how the current platform names
// binaries).
- Target dep(setup.settings(), Label(SourceDir("//foo/"), "dep"));
+ Target dep(setup.settings(), Label(SourceDir("//foo/"), "dep"), {});
dep.set_output_type(Target::ACTION);
dep.visibility().SetPublic();
dep.SetToolchain(setup.toolchain());
ASSERT_TRUE(dep.OnResolved(&err));
- Target datadep(setup.settings(), Label(SourceDir("//foo/"), "datadep"));
+ Target datadep(setup.settings(), Label(SourceDir("//foo/"), "datadep"), {});
datadep.set_output_type(Target::ACTION);
datadep.visibility().SetPublic();
datadep.SetToolchain(setup.toolchain());
ASSERT_TRUE(datadep.OnResolved(&err));
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION_FOREACH);
target.private_deps().push_back(LabelTargetPair(&dep));
target.data_deps().push_back(LabelTargetPair(&datadep));
@@ -243,7 +243,7 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION_FOREACH);
target.sources().push_back(SourceFile("//foo/input1.txt"));
@@ -305,7 +305,7 @@ TEST(NinjaActionTargetWriter, ForEachWithResponseFile) {
Err err;
TestWithScope setup;
- Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"), {});
target.set_output_type(Target::ACTION_FOREACH);
target.sources().push_back(SourceFile("//foo/input1.txt"));
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698