Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/gn/inherited_libraries_unittest.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)
Patch Set: Fix compilation after rebase. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/import_manager.cc ('k') | tools/gn/input_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/inherited_libraries_unittest.cc
diff --git a/tools/gn/inherited_libraries_unittest.cc b/tools/gn/inherited_libraries_unittest.cc
index 51152095352bc4adeb882f9a7853adb7fb9f5cdd..ed82a861d0771cf14f368fe38182735dd325b47c 100644
--- a/tools/gn/inherited_libraries_unittest.cc
+++ b/tools/gn/inherited_libraries_unittest.cc
@@ -21,8 +21,8 @@ std::pair<const Target*, bool> Pair(const Target* t, bool b) {
TEST(InheritedLibraries, Unique) {
TestWithScope setup;
- Target a(setup.settings(), Label(SourceDir("//foo/"), "a"));
- Target b(setup.settings(), Label(SourceDir("//foo/"), "b"));
+ Target a(setup.settings(), Label(SourceDir("//foo/"), "a"), {});
+ Target b(setup.settings(), Label(SourceDir("//foo/"), "b"), {});
// Setup, add the two targets as private.
InheritedLibraries libs;
@@ -61,12 +61,12 @@ TEST(InheritedLibraries, Unique) {
TEST(InheritedLibraries, AppendInherited) {
TestWithScope setup;
- Target a(setup.settings(), Label(SourceDir("//foo/"), "a"));
- Target b(setup.settings(), Label(SourceDir("//foo/"), "b"));
- Target w(setup.settings(), Label(SourceDir("//foo/"), "w"));
- Target x(setup.settings(), Label(SourceDir("//foo/"), "x"));
- Target y(setup.settings(), Label(SourceDir("//foo/"), "y"));
- Target z(setup.settings(), Label(SourceDir("//foo/"), "z"));
+ Target a(setup.settings(), Label(SourceDir("//foo/"), "a"), {});
+ Target b(setup.settings(), Label(SourceDir("//foo/"), "b"), {});
+ Target w(setup.settings(), Label(SourceDir("//foo/"), "w"), {});
+ Target x(setup.settings(), Label(SourceDir("//foo/"), "x"), {});
+ Target y(setup.settings(), Label(SourceDir("//foo/"), "y"), {});
+ Target z(setup.settings(), Label(SourceDir("//foo/"), "z"), {});
InheritedLibraries libs;
libs.Append(&a, false);
@@ -111,18 +111,18 @@ TEST(InheritedLibraries, AppendPublicSharedLibraries) {
InheritedLibraries append;
// Two source sets.
- Target set_pub(setup.settings(), Label(SourceDir("//foo/"), "set_pub"));
+ Target set_pub(setup.settings(), Label(SourceDir("//foo/"), "set_pub"), {});
set_pub.set_output_type(Target::SOURCE_SET);
append.Append(&set_pub, true);
- Target set_priv(setup.settings(), Label(SourceDir("//foo/"), "set_priv"));
+ Target set_priv(setup.settings(), Label(SourceDir("//foo/"), "set_priv"), {});
set_priv.set_output_type(Target::SOURCE_SET);
append.Append(&set_priv, false);
// Two shared libraries.
- Target sh_pub(setup.settings(), Label(SourceDir("//foo/"), "sh_pub"));
+ Target sh_pub(setup.settings(), Label(SourceDir("//foo/"), "sh_pub"), {});
sh_pub.set_output_type(Target::SHARED_LIBRARY);
append.Append(&sh_pub, true);
- Target sh_priv(setup.settings(), Label(SourceDir("//foo/"), "sh_priv"));
+ Target sh_priv(setup.settings(), Label(SourceDir("//foo/"), "sh_priv"), {});
sh_priv.set_output_type(Target::SHARED_LIBRARY);
append.Append(&sh_priv, false);
« no previous file with comments | « tools/gn/import_manager.cc ('k') | tools/gn/input_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698