tools/gn/function_toolchain.cc - Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_toolchain.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)

Patch Set: Use base::flat_set instead of std::set. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_toolchain.cc

diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc

index 05c764bfbdf65ab5524c8c15ae48221b7a2d63dc..610b26f4778953ba2afbe7b32d85ed04cf5be903 100644

--- a/tools/gn/function_toolchain.cc

+++ b/tools/gn/function_toolchain.cc

@@ -453,7 +453,8 @@ Value RunToolchain(Scope* scope,

// This object will actually be copied into the one owned by the toolchain

// manager, but that has to be done in the lock.

- std::unique_ptr<Toolchain> toolchain(new Toolchain(scope->settings(), label));

+ std::unique_ptr<Toolchain> toolchain(

+ new Toolchain(scope->settings(), label, scope->input_files()));

toolchain->set_defined_from(function);

toolchain->visibility().SetPublic();