tools/gn/filesystem_utils_unittest.cc - Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/filesystem_utils_unittest.cc

Issue 2940873002: Implement tracking of BUILD.gn files used to define target, toolchain or (Closed)

Patch Set: Use base::flat_set instead of std::set. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/filesystem_utils_unittest.cc

diff --git a/tools/gn/filesystem_utils_unittest.cc b/tools/gn/filesystem_utils_unittest.cc

index f5724c43de83539928115737284028087ffb310c..3cc24919cc410591df96fa4eb0f75241f6c83cb6 100644

--- a/tools/gn/filesystem_utils_unittest.cc

+++ b/tools/gn/filesystem_utils_unittest.cc

@@ -769,7 +769,7 @@ TEST(FilesystemUtils, GetBuildDirForTarget) {

build_settings.SetBuildDir(SourceDir("//out/Debug/"));

Settings settings(&build_settings, "");

- Target a(&settings, Label(SourceDir("//foo/bar/"), "baz"));

+ Target a(&settings, Label(SourceDir("//foo/bar/"), "baz"), {});

EXPECT_EQ("//out/Debug/obj/foo/bar/",

GetBuildDirForTargetAsSourceDir(&a, BuildDirType::OBJ).value());

EXPECT_EQ("obj/foo/bar/",