Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2940863005: Move loading methods from WebFrame to WebLocalFrame. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 25c4c424e110b3d1b5930546dac898489c0d09f5..a003debe097e54eaf930fa06ceb63c25b56b9ee1 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -362,9 +362,9 @@ TEST_P(WebViewTest, BrokenImage) {
KURL(ToKURL(base_url_), "non_existent.png"));
std::string url = RegisterMockedHttpURLLoad("image-broken.html");
- WebView* web_view = web_view_helper_.Initialize();
+ WebViewBase* web_view = web_view_helper_.Initialize();
web_view->GetSettings()->SetLoadsImagesAutomatically(true);
- LoadFrame(web_view->MainFrame(), url);
+ LoadFrame(web_view->MainFrameImpl(), url);
web_view->Resize(WebSize(400, 400));
std::string image_url = "http://www.test.com/non_existent.png";
@@ -379,9 +379,9 @@ TEST_P(WebViewTest, BrokenInputImage) {
KURL(ToKURL(base_url_), "non_existent.png"));
std::string url = RegisterMockedHttpURLLoad("input-image-broken.html");
- WebView* web_view = web_view_helper_.Initialize();
+ WebViewBase* web_view = web_view_helper_.Initialize();
web_view->GetSettings()->SetLoadsImagesAutomatically(true);
- LoadFrame(web_view->MainFrame(), url);
+ LoadFrame(web_view->MainFrameImpl(), url);
web_view->Resize(WebSize(400, 400));
std::string image_url = "http://www.test.com/non_existent.png";
@@ -578,8 +578,8 @@ TEST_P(WebViewTest, HitTestResultAtWithPageScaleAndPan) {
std::string url = base_url_ + "specify_size.html?" + "50px" + ":" + "50px";
URLTestHelpers::RegisterMockedURLLoad(
ToKURL(url), testing::WebTestDataPath("specify_size.html"));
- WebView* web_view = web_view_helper_.Initialize(true);
- LoadFrame(web_view->MainFrame(), url);
+ WebViewBase* web_view = web_view_helper_.Initialize(true);
+ LoadFrame(web_view->MainFrameImpl(), url);
web_view->Resize(WebSize(100, 100));
WebPoint hit_point(75, 75);
@@ -633,8 +633,8 @@ TEST_P(WebViewTest, HitTestResultForTapWithTapArea) {
TEST_P(WebViewTest, HitTestResultForTapWithTapAreaPageScaleAndPan) {
std::string url = RegisterMockedHttpURLLoad("hit_test.html");
- WebView* web_view = web_view_helper_.Initialize(true);
- LoadFrame(web_view->MainFrame(), url);
+ WebViewBase* web_view = web_view_helper_.Initialize(true);
+ LoadFrame(web_view->MainFrameImpl(), url);
web_view->Resize(WebSize(100, 100));
WebPoint hit_point(55, 55);
@@ -3210,7 +3210,7 @@ TEST_P(WebViewTest, AddFrameInNavigateUnload) {
RegisterMockedHttpURLLoad("add_frame_in_unload.html");
web_view_helper_.InitializeAndLoad(base_url_ + "add_frame_in_unload.html",
true, &frame_client);
- FrameTestHelpers::LoadFrame(web_view_helper_.WebView()->MainFrame(),
+ FrameTestHelpers::LoadFrame(web_view_helper_.WebView()->MainFrameImpl(),
"about:blank");
EXPECT_EQ(0, frame_client.Count());
web_view_helper_.Reset();
@@ -3222,7 +3222,7 @@ TEST_P(WebViewTest, AddFrameInChildInNavigateUnload) {
RegisterMockedHttpURLLoad("add_frame_in_unload.html");
web_view_helper_.InitializeAndLoad(
base_url_ + "add_frame_in_unload_wrapper.html", true, &frame_client);
- FrameTestHelpers::LoadFrame(web_view_helper_.WebView()->MainFrame(),
+ FrameTestHelpers::LoadFrame(web_view_helper_.WebView()->MainFrameImpl(),
"about:blank");
EXPECT_EQ(1, frame_client.Count());
web_view_helper_.Reset();
@@ -3558,10 +3558,10 @@ TEST_P(WebViewTest, CompareSelectAllToContentAsText) {
TEST_P(WebViewTest, AutoResizeSubtreeLayout) {
std::string url = RegisterMockedHttpURLLoad("subtree-layout.html");
- WebView* web_view = web_view_helper_.Initialize(true);
+ WebViewBase* web_view = web_view_helper_.Initialize(true);
web_view->EnableAutoResizeMode(WebSize(200, 200), WebSize(200, 200));
- LoadFrame(web_view->MainFrame(), url);
+ LoadFrame(web_view->MainFrameImpl(), url);
LocalFrameView* frame_view =
web_view_helper_.WebView()->MainFrameImpl()->GetFrameView();

Powered by Google App Engine
This is Rietveld 408576698