Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2940843005: Remove an unnecessary null check (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-15 14:03:00 UTC) #2
Paul Berry
https://codereview.chromium.org/2940843005/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right): https://codereview.chromium.org/2940843005/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart#newcode2267 pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:2267: closureContext.isGenerator ? closureContext.returnContext : null; Note that the use ...
3 years, 6 months ago (2017-06-15 16:33:34 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-15 22:35:24 UTC) #5
Paul Berry
Committed patchset #1 (id:1) manually as cd1cd49f490ed03ce841f7f5477f96d938e9ed95 (presubmit successful).
3 years, 6 months ago (2017-06-16 03:44:42 UTC) #7
scheglov
3 years, 6 months ago (2017-06-16 15:41:53 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698