Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2940843003: Ignore recoverable parser errors in outline_builder to avoid double reporting. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore recoverable parser errors in outline_builder to avoid double reporting. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/246334011a612928094a9d17e05a744bfccb91c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-14 16:51:03 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-14 16:52:21 UTC) #3
ahe
3 years, 6 months ago (2017-06-14 17:14:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
246334011a612928094a9d17e05a744bfccb91c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698