Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: src/objects.h

Issue 294083002: Simplify declaration of KindSpecificFlags1 fields. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index d642e1e7da88b4f57bf49f79b485031f771a1ef3..837797972259ee82fb93c59f80bf82246cbcca92 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5707,37 +5707,28 @@ class Code: public HeapObject {
// KindSpecificFlags1 layout (STUB and OPTIMIZED_FUNCTION)
static const int kStackSlotsFirstBit = 0;
static const int kStackSlotsBitCount = 24;
- static const int kHasFunctionCacheFirstBit =
- kStackSlotsFirstBit + kStackSlotsBitCount;
- static const int kHasFunctionCacheBitCount = 1;
- static const int kMarkedForDeoptimizationFirstBit =
+ static const int kHasFunctionCacheBit =
+ kStackSlotsFirstBit + kStackSlotsBitCount + 0;
+ static const int kMarkedForDeoptimizationBit =
kStackSlotsFirstBit + kStackSlotsBitCount + 1;
- static const int kMarkedForDeoptimizationBitCount = 1;
- static const int kWeakStubFirstBit =
- kMarkedForDeoptimizationFirstBit + kMarkedForDeoptimizationBitCount;
- static const int kWeakStubBitCount = 1;
- static const int kInvalidatedWeakStubFirstBit =
- kWeakStubFirstBit + kWeakStubBitCount;
- static const int kInvalidatedWeakStubBitCount = 1;
+ static const int kWeakStubBit =
+ kStackSlotsFirstBit + kStackSlotsBitCount + 2;
+ static const int kInvalidatedWeakStubBit =
+ kStackSlotsFirstBit + kStackSlotsBitCount + 3;
STATIC_ASSERT(kStackSlotsFirstBit + kStackSlotsBitCount <= 32);
- STATIC_ASSERT(kHasFunctionCacheFirstBit + kHasFunctionCacheBitCount <= 32);
- STATIC_ASSERT(kInvalidatedWeakStubFirstBit +
- kInvalidatedWeakStubBitCount <= 32);
+ STATIC_ASSERT(kInvalidatedWeakStubBit + 1 <= 32);
class StackSlotsField: public BitField<int,
kStackSlotsFirstBit, kStackSlotsBitCount> {}; // NOLINT
class HasFunctionCacheField: public BitField<bool,
- kHasFunctionCacheFirstBit, kHasFunctionCacheBitCount> {}; // NOLINT
+ kHasFunctionCacheBit, 1> {}; // NOLINT
class MarkedForDeoptimizationField: public BitField<bool,
- kMarkedForDeoptimizationFirstBit,
- kMarkedForDeoptimizationBitCount> {}; // NOLINT
+ kMarkedForDeoptimizationBit, 1> {}; // NOLINT
class WeakStubField: public BitField<bool,
- kWeakStubFirstBit,
- kWeakStubBitCount> {}; // NOLINT
+ kWeakStubBit, 1> {}; // NOLINT
class InvalidatedWeakStubField: public BitField<bool,
- kInvalidatedWeakStubFirstBit,
- kInvalidatedWeakStubBitCount> {}; // NOLINT
+ kInvalidatedWeakStubBit, 1> {}; // NOLINT
// KindSpecificFlags2 layout (ALL)
static const int kIsCrankshaftedBit = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698