Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2940783002: update analyzer tests for fasta scanner (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M pkg/analyzer/test/src/task/dart_test.dart View 1 4 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 6 months ago (2017-06-14 03:13:56 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2940783002/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/2940783002/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode3267 pkg/analyzer/test/src/task/dart_test.dart:3267: expect(outputs[PARSE_ERRORS], hasLength(0)); Can we check for scanner errors ...
3 years, 6 months ago (2017-06-14 04:17:24 UTC) #3
danrubel
https://codereview.chromium.org/2940783002/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/2940783002/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode3267 pkg/analyzer/test/src/task/dart_test.dart:3267: expect(outputs[PARSE_ERRORS], hasLength(0)); On 2017/06/14 04:17:24, Brian Wilkerson wrote: > ...
3 years, 6 months ago (2017-06-14 06:28:58 UTC) #4
danrubel
3 years, 6 months ago (2017-06-14 15:17:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b03ff5c772e55778271db55f2015edcee0e38fa3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698