Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 294073009: Save running SW instance info, including its SiteInstance, into the ProcessManager. (Closed)

Created:
6 years, 7 months ago by Jeffrey Yasskin
Modified:
6 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Save running SW instance info, including its SiteInstance, into the ProcessManager. We can use this map to drop all the process references on shutdown, in order to fix http://crbug.com/368570. This starts to fix an assumption in the content layer that SiteInstances outlive their RPHs so that process permissions can be controlled through the SiteInstance instead of by process id. However, there's still work to do before that's completely fixed. This reverts https://codereview.chromium.org/296053013/ and avoids the incorrect down-cast that caused https://codereview.chromium.org/292903002 to break the Asan bot. BUG=368570 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272490

Patch Set 1 #

Patch Set 2 : Test SortProcesses without doing all the work to Start an instance. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -85 lines) Patch
M content/browser/service_worker/embedded_worker_instance.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 3 chunks +18 lines, -17 lines 1 comment Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 5 chunks +31 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.h View 3 chunks +46 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 4 chunks +67 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeffrey Yasskin
In writing the ChooseProcess test with a MockRenderProcessHost, I forgot that part of the implementation ...
6 years, 7 months ago (2014-05-22 22:13:34 UTC) #1
kinuko
lgtm
6 years, 7 months ago (2014-05-23 02:51:19 UTC) #2
kinuko
https://codereview.chromium.org/294073009/diff/20001/content/browser/service_worker/embedded_worker_instance_unittest.cc File content/browser/service_worker/embedded_worker_instance_unittest.cc (right): https://codereview.chromium.org/294073009/diff/20001/content/browser/service_worker/embedded_worker_instance_unittest.cc#newcode150 content/browser/service_worker/embedded_worker_instance_unittest.cc:150: testing::ElementsAre(3, 2, 1)); Neat, didn't know this notation.
6 years, 7 months ago (2014-05-23 02:53:23 UTC) #3
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-23 02:53:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/294073009/20001
6 years, 7 months ago (2014-05-23 02:55:23 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:29:23 UTC) #6
Message was sent while issue was closed.
Change committed as 272490

Powered by Google App Engine
This is Rietveld 408576698