Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js

Issue 294073007: [fsp] Let extensions decide about the file system id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js b/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
index 9f7384f8f4a842965c6b540e17605283d64d2582..a2a64230dd54932077177cbf8dd282b265f02be2 100644
--- a/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
@@ -44,24 +44,22 @@ binding.registerCustomHook(function(bindingsAPI) {
apiFunctions.setUpdateArgumentsPostValidate(
'mount',
- function(displayName, successCallback, errorCallback) {
+ function(fileSystemId, displayName, successCallback, errorCallback) {
// Piggyback the error callback onto the success callback,
// so we can use the error callback later.
successCallback.errorCallback_ = errorCallback;
- return [displayName, successCallback];
+ return [fileSystemId, displayName, successCallback];
});
apiFunctions.setCustomCallback(
'mount',
function(name, request, response) {
- var fileSystemId = null;
var domError = null;
if (request.callback && response) {
- fileSystemId = response[0];
// DOMError is present only if mount() failed.
- if (response[1]) {
+ if (response[0]) {
// Convert a Dictionary to a DOMError.
- domError = GetDOMError(response[1].name, response[1].message);
+ domError = GetDOMError(response[0].name, response[0].message);
response.length = 1;
}
@@ -72,7 +70,7 @@ binding.registerCustomHook(function(bindingsAPI) {
if (domError)
errorCallback(domError);
else
- successCallback(fileSystemId);
+ successCallback();
}
});

Powered by Google App Engine
This is Rietveld 408576698