Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 294073007: [fsp] Let extensions decide about the file system id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
index 01108cfad962335bacd87accac173500d503e67e..3341d7e6bf3efaf874784de14d2311c6f53b8b52 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
@@ -24,7 +24,7 @@ namespace operations {
namespace {
const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
-const int kFileSystemId = 1;
+const char kFileSystemId[] = "testing-file-system";
const int kRequestId = 2;
const int kFileHandle = 3;
const int kOffset = 10;
@@ -140,8 +140,8 @@ TEST_F(FileSystemProviderOperationsReadFileTest, Execute) {
base::ListValue* event_args = event->event_args.get();
ASSERT_EQ(5u, event_args->GetSize());
- int event_file_system_id = -1;
- EXPECT_TRUE(event_args->GetInteger(0, &event_file_system_id));
+ std::string event_file_system_id;
+ EXPECT_TRUE(event_args->GetString(0, &event_file_system_id));
EXPECT_EQ(kFileSystemId, event_file_system_id);
int event_request_id = -1;
@@ -205,7 +205,7 @@ TEST_F(FileSystemProviderOperationsReadFileTest, OnSuccess) {
const bool has_next = false;
base::ListValue value_as_list;
- value_as_list.Set(0, new base::FundamentalValue(kFileSystemId));
+ value_as_list.Set(0, new base::StringValue(kFileSystemId));
value_as_list.Set(1, new base::FundamentalValue(kRequestId));
value_as_list.Set(
2, base::BinaryValue::CreateWithCopiedBuffer(data.c_str(), data.size()));

Powered by Google App Engine
This is Rietveld 408576698