chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc - Issue 294073007: [fsp] Let extensions decide about the file system id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

Issue 294073007: [fsp] Let extensions decide about the file system id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

index 8f4b34d7c577fc96a9df6c1123a4d8d337c6debc..ced57c438d18a929f2247bc0d38215a26d305975 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

@@ -23,7 +23,7 @@ namespace operations {

namespace {

const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";

-const int kFileSystemId = 1;

+const char kFileSystemId[] = "testing-file-system";

const int kRequestId = 2;

const base::FilePath::CharType kFilePath[] = "/directory/blueberries.txt";

@@ -132,8 +132,8 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute) {

base::ListValue* event_args = event->event_args.get();

ASSERT_EQ(5u, event_args->GetSize());

- int event_file_system_id = -1;

- EXPECT_TRUE(event_args->GetInteger(0, &event_file_system_id));

+ std::string event_file_system_id;

+ EXPECT_TRUE(event_args->GetString(0, &event_file_system_id));

EXPECT_EQ(kFileSystemId, event_file_system_id);

int event_request_id = -1;

@@ -175,7 +175,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute_NoListener) {

}

TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {

- using extensions::api::file_system_provider::EntryMetadata;

using extensions::api::file_system_provider_internal::

OpenFileRequestedSuccess::Params;

@@ -205,7 +204,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {

}

TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {

- using extensions::api::file_system_provider::EntryMetadata;

using extensions::api::file_system_provider_internal::OpenFileRequestedError::

Params;