chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc - Issue 294073007: [fsp] Let extensions decide about the file system id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc

Issue 294073007: [fsp] Let extensions decide about the file system id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/mount_path_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc b/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc

index 4f80a4058192338f755947a01a2b3172235e42f2..b831d065de0c818fdde3060294a6c72e57365ac7 100644

--- a/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc

@@ -33,6 +33,7 @@ namespace file_system_provider {

namespace {

const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";

+const char kFileSystemId[] = "testing-file-system";

// Logs callbacks invocations on the tested operations.

// TODO(mtomasz): Store and verify more arguments, once the operations return

@@ -139,11 +140,11 @@ class FileSystemProviderProviderAsyncFileUtilTest : public testing::Test {

service->SetFileSystemFactoryForTests(

base::Bind(&FakeProvidedFileSystem::Create));

- const int file_system_id =

- service->MountFileSystem(kExtensionId, "testing-file-system");

- ASSERT_LT(0, file_system_id);

+ const bool result = service->MountFileSystem(

+ kExtensionId, kFileSystemId, "Testing File System");

+ ASSERT_TRUE(result);

const ProvidedFileSystemInfo& file_system_info =

- service->GetProvidedFileSystem(kExtensionId, file_system_id)

+ service->GetProvidedFileSystem(kExtensionId, kFileSystemId)

->GetFileSystemInfo();

const std::string mount_point_name =

file_system_info.mount_path().BaseName().AsUTF8Unsafe();