chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc - Issue 294073007: [fsp] Let extensions decide about the file system id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

Issue 294073007: [fsp] Let extensions decide about the file system id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/provider_function.h ('k') | chrome/browser/chromeos/file_manager/volume_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

diff --git a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

index 53a3206a5db01e0d6f297b6dddf02d72ab4ed3b5..622d39c0f1ad14d96012a9dbc989d0f4669519cf 100644

--- a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

+++ b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

@@ -21,6 +21,7 @@ const char kNotFoundErrorName[] = "NotFoundError";

const char kSecurityErrorName[] = "SecurityError";

const char kEmptyNameErrorMessage[] = "Empty display name is not allowed.";

+const char kEmptyIdErrorMessage[] = "Empty file system Id s not allowed.";

const char kMountFailedErrorMessage[] = "Mounting the file system failed.";

const char kUnmountFailedErrorMessage[] = "Unmounting the file system failed.";

const char kResponseFailedErrorMessage[] =

@@ -104,9 +105,9 @@ bool FileSystemProviderInternalFunction::RunSync() {

}

bool FileSystemProviderInternalFunction::Parse() {

- int file_system_id = 0;

+ std::string file_system_id;

- if (!args_->GetInteger(0, &file_system_id) ||

+ if (!args_->GetString(0, &file_system_id) ||

!args_->GetInteger(1, &request_id_)) {

bad_message_ = true;

SendResponse(false);