[fsp] Let extensions decide about the file system id.

chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
+#include "base/values.h"
 #include "chrome/browser/chromeos/file_system_provider/operations/read_directory.h"
 #include "chrome/common/extensions/api/file_system_provider.h"
 #include "chrome/common/extensions/api/file_system_provider_internal.h"
 #include "extensions/browser/event_router.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/browser/fileapi/async_file_util.h"
 
 namespace chromeos {
 namespace file_system_provider {
 namespace operations {
 namespace {
 
 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
-const int kFileSystemId = 1;
+const char kFileSystemId[] = "testing-file-system";
 const int kRequestId = 2;
 const base::FilePath::CharType kDirectoryPath[] = "/directory";
 
 // Fake event dispatcher implementation with extra logging capability. Acts as
 // a providing extension end-point.
 class LoggingDispatchEventImpl {
  public:
   explicit LoggingDispatchEventImpl(bool dispatch_reply)
       : dispatch_reply_(dispatch_reply) {}
   virtual ~LoggingDispatchEventImpl() {}
@@ skipping 94 matching lines @@
   EXPECT_TRUE(read_directory.Execute(kRequestId));
 
   ASSERT_EQ(1u, dispatcher.events().size());
   extensions::Event* event = dispatcher.events()[0];
   EXPECT_EQ(extensions::api::file_system_provider::OnReadDirectoryRequested::
                 kEventName,
             event->event_name);
   base::ListValue* event_args = event->event_args.get();
   ASSERT_EQ(3u, event_args->GetSize());
 
-  int event_file_system_id = -1;
-  EXPECT_TRUE(event_args->GetInteger(0, &event_file_system_id));
+  std::string event_file_system_id;
+  EXPECT_TRUE(event_args->GetString(0, &event_file_system_id));
   EXPECT_EQ(kFileSystemId, event_file_system_id);
 
   int event_request_id = -1;
   EXPECT_TRUE(event_args->GetInteger(1, &event_request_id));
   EXPECT_EQ(kRequestId, event_request_id);
 
   std::string event_directory_path;
   EXPECT_TRUE(event_args->GetString(2, &event_directory_path));
   EXPECT_EQ(kDirectoryPath, event_directory_path);
 }
@@ skipping 31 matching lines @@
       base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(read_directory.Execute(kRequestId));
 
   // Sample input as JSON. Keep in sync with file_system_provider_api.idl.
   // As for now, it is impossible to create *::Params class directly, not from
   // base::Value.
   const std::string input =
       "[\n"
-      "  1,\n"  // kFileSystemId
-      "  2,\n"  // kRequestId
+      "  \"testing-file-system\",\n"  // kFileSystemId
+      "  2,\n"                        // kRequestId
       "  [\n"
       "    {\n"
       "      \"isDirectory\": false,\n"
       "      \"name\": \"blueberries.txt\",\n"
       "      \"size\": 4096,\n"
       "      \"modificationTime\": {\n"
       "        \"value\": \"Thu Apr 24 00:46:52 UTC 2014\"\n"
       "      }\n"
       "    }\n"
       "  ],\n"
@@ skipping 55 matching lines @@
 
   ASSERT_EQ(1u, callback_logger.events().size());
   CallbackLogger::Event* event = callback_logger.events()[0];
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
   ASSERT_EQ(0u, event->entry_list().size());
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos