Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294073006: Remove dispatcher when shutting down RootWindowController (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Remove dispatcher when shutting down RootWindowController Resurrecting PrepareForShutdown as it can be implemented onl in ash. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272308

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/display/screen_ash.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_settings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
6 years, 7 months ago (2014-05-21 07:18:21 UTC) #1
sadrul
https://codereview.chromium.org/294073006/diff/50001/ash/display/screen_ash.cc File ash/display/screen_ash.cc (right): https://codereview.chromium.org/294073006/diff/50001/ash/display/screen_ash.cc#newcode239 ash/display/screen_ash.cc:239: if (id != gfx::Display::kInvalidDisplayID) Did you mean id == ...
6 years, 7 months ago (2014-05-21 19:01:49 UTC) #2
oshima
https://codereview.chromium.org/294073006/diff/50001/ash/display/screen_ash.cc File ash/display/screen_ash.cc (right): https://codereview.chromium.org/294073006/diff/50001/ash/display/screen_ash.cc#newcode239 ash/display/screen_ash.cc:239: if (id != gfx::Display::kInvalidDisplayID) On 2014/05/21 19:01:49, sadrul wrote: ...
6 years, 7 months ago (2014-05-22 17:03:12 UTC) #3
sadrul
lgtm https://codereview.chromium.org/294073006/diff/70001/ash/host/ash_window_tree_host.h File ash/host/ash_window_tree_host.h (right): https://codereview.chromium.org/294073006/diff/70001/ash/host/ash_window_tree_host.h#newcode58 ash/host/ash_window_tree_host.h:58: // Stop listening for events in preparatino for ...
6 years, 7 months ago (2014-05-22 17:07:56 UTC) #4
oshima
https://codereview.chromium.org/294073006/diff/70001/ash/host/ash_window_tree_host.h File ash/host/ash_window_tree_host.h (right): https://codereview.chromium.org/294073006/diff/70001/ash/host/ash_window_tree_host.h#newcode58 ash/host/ash_window_tree_host.h:58: // Stop listening for events in preparatino for shutdown. ...
6 years, 7 months ago (2014-05-22 17:15:32 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-22 17:15:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/294073006/40011
6 years, 7 months ago (2014-05-22 17:18:12 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 20:36:14 UTC) #8
Message was sent while issue was closed. 
Change committed as 272308

Powered by Google App Engine
This is Rietveld 408576698