Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2940723002: Exclude 'test' and 'testcases' from lib/ packages. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 6 months ago (2017-06-13 20:19:47 UTC) #1
Paul Berry
lgtm assuming Bill agrees
3 years, 6 months ago (2017-06-13 20:23:32 UTC) #2
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-14 09:56:34 UTC) #3
scheglov
3 years, 6 months ago (2017-06-14 14:50:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2b98bb8fd1d6e76161db6142ea3f100dd557ae8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698