Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2940643002: Fix memory leak in test. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Take II #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/front_end/test/fasta/testing/suite.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-13 14:06:00 UTC) #2
Paul Berry
This must not be the only leak. I'm still seeing out of memory errors.
3 years, 6 months ago (2017-06-13 14:14:25 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-06-13 14:26:18 UTC) #4
ahe
3 years, 6 months ago (2017-06-13 15:17:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
73107ed49eba8309dd39ec14eb9676aa2b5c8816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698