Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: content/browser/blob_storage/blob_url_loader_factory.cc

Issue 2940553003: Failure in reading Blob URL should results in network error
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/blob_storage/blob_url_loader_factory.cc
diff --git a/content/browser/blob_storage/blob_url_loader_factory.cc b/content/browser/blob_storage/blob_url_loader_factory.cc
index 1dbcb19020438095ffeeeeac5d826163e86d4132..9778213c53930e2ae4fb82afa5a5f01cb8c11eb8 100644
--- a/content/browser/blob_storage/blob_url_loader_factory.cc
+++ b/content/browser/blob_storage/blob_url_loader_factory.cc
@@ -136,15 +136,8 @@ class BlobURLLoader : public mojom::URLLoader {
// object now if possible (i.e. no outstanding data pipe), otherwise this
// object will be deleted when the data pipe is closed.
void NotifyCompleted(int error_code) {
- if (error_code != net::OK && !sent_headers_) {
- net::HttpStatusCode status_code =
- storage::BlobURLRequestJob::NetErrorToHttpStatusCode(error_code);
- ResourceResponseHead response;
- response.headers = storage::BlobURLRequestJob::GenerateHeaders(
- status_code, nullptr, nullptr, nullptr, nullptr);
- client_->OnReceiveResponse(response, base::nullopt, nullptr);
- }
ResourceRequestCompletionStatus request_complete_data;
+ request_complete_data.error_code = error_code;
client_->OnComplete(request_complete_data);
DeleteIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698