Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 294053014: Revert of Add native X11 testing to chromeos::EventRewriter unit tests (Closed)

Created:
6 years, 7 months ago by kpschoedel
Modified:
6 years, 6 months ago
Reviewers:
sadrul, Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add native X11 testing to chromeos::EventRewriter unit tests (https://codereview.chromium.org/270633012/) Reason for revert: Some key codes are not recognized by the X server used by valgrind tests, leading to test failures. http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/26006/steps/memory%20test%3A%20unit/logs/EventRewriterTest.TestRewriteFunctionKeys Original issue's description: > Add native event testing to chromeos::EventRewriter unit tests. > > Most tests (not having state) are converted to a table-driven form, > so that multiple test operations can be done on the same test data. > Additional tests based on X11 native events are done on these cases. > > The fallback X11 keycode to keysym mapping is expanded, because the > X server used by some automated tests does not support some of the > keycodes used by ChromeOS top-row special keys. > > > R=sadrul@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+920 lines, -1077 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 18 chunks +832 lines, -921 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.cc View 1 chunk +88 lines, -151 lines 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kpschoedel
Created Revert of Add native X11 testing to chromeos::EventRewriter unit tests
6 years, 7 months ago (2014-05-23 14:02:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/294053014/1
6 years, 7 months ago (2014-05-23 14:02:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 14:02:56 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 14:02:56 UTC) #4
Daniel Erat
lgtm
6 years, 7 months ago (2014-05-23 14:03:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 17:13:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 17:17:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69524)
6 years, 7 months ago (2014-05-23 17:17:25 UTC) #8
sadrul
lgtm
6 years, 7 months ago (2014-05-23 22:25:52 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 00:03:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 00:09:21 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:09:21 UTC) #12
Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

Powered by Google App Engine
This is Rietveld 408576698