Source/modules/webaudio/MediaElementAudioSourceNode.cpp - Issue 294053006: Oilpan: Use transition types for HTMLMediaElement and make AudioSourceProviderClient a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 294053006: Oilpan: Use transition types for HTMLMediaElement and make AudioSourceProviderClient a GC mixin. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/modules/webaudio/MediaElementAudioSourceNode.h ('k') | Source/modules/webaudio/MediaStreamAudioSourceNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

diff --git a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

index 2b4bb42e78c33ffb997d68873cb345b8b8e3e718..ac3f7443b93af7d090634808c65838e122ffc711 100644

--- a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

+++ b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -63,7 +63,9 @@ MediaElementAudioSourceNode::MediaElementAudioSourceNode(AudioContext* context,

MediaElementAudioSourceNode::~MediaElementAudioSourceNode()

{

+#if !ENABLE(OILPAN)

m_mediaElement->setAudioSourceNode(0);

+#endif

uninitialize();

}

@@ -148,6 +150,13 @@ void MediaElementAudioSourceNode::unlock()

deref();

}

+void MediaElementAudioSourceNode::trace(Visitor* visitor)

+ visitor->trace(m_mediaElement);

+ AudioSourceNode::trace(visitor);

+ AudioSourceProviderClient::trace(visitor);

} // namespace WebCore

#endif // ENABLE(WEB_AUDIO)