Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 294053006: Oilpan: Use transition types for HTMLMediaElement and make AudioSourceProviderClient a GC mixin. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 7160b0def0089719ac75e40823c95de1dcd7c0b6..e75051ec6b2446a68b00e196bd1116f2927beb56 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -514,7 +514,7 @@ private:
#if ENABLE(WEB_AUDIO)
// This is a weak reference, since m_audioSourceNode holds a reference to us.
- AudioSourceProviderClient* m_audioSourceNode;
+ RawPtrWillBeMember<AudioSourceProviderClient> m_audioSourceNode;
haraken 2014/05/21 16:35:58 Shouldn't this be a weak member?
zerny-chromium 2014/05/22 05:54:32 It appears to be raw simply to break what would ot
haraken 2014/05/22 07:33:36 In the current implementation, it looks like that
Mads Ager (chromium) 2014/05/22 08:02:56 I think what that comment is saying is that this i
#endif
friend class MediaController;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698