Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3787)

Unified Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 294053002: Split regular and perf WebRTC browser tests, remove CPU test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing js files that accidentally got uploaded Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
index 0ed5934bf3a5f1c152ed8265b138c6f360792fcb..fd5da476634113487142fcd32b0b9ed066b6947a 100644
--- a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
@@ -32,11 +32,6 @@
#include "testing/perf/perf_test.h"
#include "ui/gl/gl_switches.h"
-// For fine-grained suppression on flaky tests.
-#if defined(OS_WIN)
-#include "base/win/windows_version.h"
-#endif
-
static const base::FilePath::CharType kFrameAnalyzerExecutable[] =
#if defined(OS_WIN)
FILE_PATH_LITERAL("frame_analyzer.exe");
@@ -320,12 +315,8 @@ INSTANTIATE_TEST_CASE_P(
IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
MANUAL_TestVideoQuality) {
-
-#if defined(OS_WIN)
- // Fails on XP. http://crbug.com/353078
- if (base::win::GetVersion() <= base::win::VERSION_XP)
- return;
-#endif
+ if (OnWinXp())
+ return; // Fails on XP. http://crbug.com/353078.
ASSERT_GE(TestTimeouts::action_max_timeout().InSeconds(), 150) <<
"This is a long-running test; you must specify "
« no previous file with comments | « chrome/browser/media/chrome_webrtc_typing_detection_browsertest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698