Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 294053002: Split regular and perf WebRTC browser tests, remove CPU test. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

This splits the main browser test so the webrtc-internals perf test is the only one to run with a reference file and moves the normal tests to use the generating fake device (i.e. the spinning green ball). This is fine since the main test doesn't care, whereas the perf test must have a somewhat realistic video to give realistic encode/decode numbers. The CPU test can be thrown away since we have telemetry tests for that now. BUG=375240 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272828

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Cleaning includes #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Adding back MANUAL tags. #

Total comments: 4

Patch Set 6 : Removed resource checks #

Patch Set 7 : Removing js files that accidentally got uploaded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -220 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 2 3 4 5 4 chunks +7 lines, -198 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
A chrome/browser/media/chrome_webrtc_perf_browsertest.cc View 1 2 3 1 chunk +133 lines, -0 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_typing_detection_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
phoglund_chromium
kjellander: main review tommi: owner stamp https://codereview.chromium.org/294053002/diff/60001/chrome/browser/media/chrome_webrtc_perf_browsertest.cc File chrome/browser/media/chrome_webrtc_perf_browsertest.cc (right): https://codereview.chromium.org/294053002/diff/60001/chrome/browser/media/chrome_webrtc_perf_browsertest.cc#newcode1 chrome/browser/media/chrome_webrtc_perf_browsertest.cc:1: // Copyright 2014 ...
6 years, 7 months ago (2014-05-20 12:43:40 UTC) #1
kjellander_chromium
I suggest doing all preparations in one CL so that "make tree closing" can be ...
6 years, 7 months ago (2014-05-20 12:53:28 UTC) #2
phoglund_chromium
On 2014/05/20 12:53:28, kjellander wrote: > I suggest doing all preparations in one CL so ...
6 years, 7 months ago (2014-05-20 12:56:08 UTC) #3
phoglund_chromium
On 2014/05/20 12:56:08, phoglund wrote: > On 2014/05/20 12:53:28, kjellander wrote: > > I suggest ...
6 years, 7 months ago (2014-05-22 17:38:11 UTC) #4
kjellander_chromium
Please update the title and mention which tests you're going to make tree closing in ...
6 years, 7 months ago (2014-05-22 18:45:58 UTC) #5
phoglund_chromium
PTAL https://codereview.chromium.org/294053002/diff/80001/chrome/browser/media/chrome_webrtc_browsertest.cc File chrome/browser/media/chrome_webrtc_browsertest.cc (right): https://codereview.chromium.org/294053002/diff/80001/chrome/browser/media/chrome_webrtc_browsertest.cc#newcode53 chrome/browser/media/chrome_webrtc_browsertest.cc:53: ASSERT_TRUE(test::HasReferenceFilesInCheckout()); On 2014/05/22 18:45:59, kjellander wrote: > This ...
6 years, 7 months ago (2014-05-23 07:55:42 UTC) #6
kjellander_chromium
lgtm!
6 years, 7 months ago (2014-05-23 08:05:45 UTC) #7
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-23 08:51:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/294053002/110001
6 years, 7 months ago (2014-05-23 08:52:50 UTC) #9
phoglund_chromium
tommi: owner stamp?
6 years, 7 months ago (2014-05-23 09:25:15 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 11:10:11 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 11:14:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69459)
6 years, 7 months ago (2014-05-23 11:14:28 UTC) #13
tommi (sloooow) - chröme
rs lgtm
6 years, 7 months ago (2014-05-23 11:39:53 UTC) #14
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-23 12:12:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/294053002/110001
6 years, 7 months ago (2014-05-23 12:12:28 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 13:42:47 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 17:52:26 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32114)
6 years, 7 months ago (2014-05-23 17:52:26 UTC) #19
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-26 07:52:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/294053002/110001
6 years, 7 months ago (2014-05-26 07:52:23 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 15:49:11 UTC) #22
Message was sent while issue was closed.
Change committed as 272828

Powered by Google App Engine
This is Rietveld 408576698