Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2940523003: Cleaned analysis result for observatory (Closed)

Created:
3 years, 6 months ago by cbernaschina
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -70 lines) Patch
M runtime/observatory/.analysis_options View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/service_html.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_exception_test.dart View 1 chunk +7 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_into_test.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_out_test.dart View 1 chunk +5 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/async_star_single_step_into_test.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/async_star_step_out_test.dart View 1 chunk +9 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/async_step_out_test.dart View 1 chunk +5 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_with_scope_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_object_store_rpc_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
cbernaschina
3 years, 6 months ago (2017-06-13 22:19:38 UTC) #3
rmacnak
lgtm
3 years, 6 months ago (2017-06-13 22:30:53 UTC) #4
cbernaschina
3 years, 6 months ago (2017-06-14 19:23:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e826fdcb6b840e4636f4420524ce41bc2fef7615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698